Use of “counterparty” is confusing

[fulldecent]

Griefing contracts use the word “punisher” and “counterparty” interchangeably.

Also, in the advertised use cases, both the seller and buyer will be a “counterparty” for different agreements related to the same transaction.

Lastly, “counterparty” has a natural meaning in commerce.

These reasons contribute to the word potentially being misunderstood.

Inconsistency and lack of clarity create a risk of users misunderstanding the operation of the product.

Recommendation: entirely abandon the use of “counterparty” and adopt “punisher” to improve clarity and concrete, literal prose.

References:

• Punisher example: https://github.com/erasureprotocol/erasure-protocol/blob/4a3d98ce023a264a9f3c7ba62ef77a9207bba5fe/contracts/modules/Griefing.sol#L23
• Counterparty example: https://github.com/erasureprotocol/erasure-protocol/blob/4a3d98ce023a264a9f3c7ba62ef77a9207bba5fe/contracts/agreements/CountdownGriefing.sol#L25

[thegostep]

I agree with the recommendation, but will slate for future release.