eraser icon indicating copy to clipboard operation
eraser copied to clipboard

feat: eraser metrics

Open ashnamehrotra opened this issue 3 years ago • 1 comments

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged): Fixes #38

Special notes for your reviewer:

ashnamehrotra avatar Oct 07 '22 20:10 ashnamehrotra

Codecov Report

Merging #420 (e0f0b64) into main (75a5454) will increase coverage by 1.24%. The diff coverage is 23.03%.

:exclamation: Current head e0f0b64 differs from pull request most recent head ddc428f. Consider uploading reports for the commit ddc428f to get more accurate results

@@            Coverage Diff             @@
##             main     #420      +/-   ##
==========================================
+ Coverage   13.02%   14.27%   +1.24%     
==========================================
  Files          12       13       +1     
  Lines        1328     1506     +178     
==========================================
+ Hits          173      215      +42     
- Misses       1137     1264     +127     
- Partials       18       27       +9     
Flag Coverage Δ
unittests 14.27% <23.03%> (+1.24%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/eraser/eraser.go 0.00% <0.00%> (ø)
pkg/scanners/trivy/trivy.go 0.00% <0.00%> (ø)
test/e2e/util/kubectl.go 0.00% <0.00%> (ø)
test/e2e/util/utils.go 6.87% <0.00%> (-0.39%) :arrow_down:
pkg/metrics/metrics.go 48.71% <48.71%> (ø)
pkg/eraser/helpers.go 72.15% <75.00%> (+1.48%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Oct 07 '22 20:10 codecov-commenter

You'll need to merge with main

pmengelbert avatar Nov 22 '22 21:11 pmengelbert

@ashnamehrotra needs a merge with main

pmengelbert avatar Nov 28 '22 16:11 pmengelbert

@pmengelbert please review again when you get a chance please

sozercan avatar Dec 01 '22 21:12 sozercan

There's a few small changes left, but otherwise LGTM. Should be able to merge this today

pmengelbert avatar Dec 02 '22 15:12 pmengelbert