eraser icon indicating copy to clipboard operation
eraser copied to clipboard

Windows docker build

Open vyta opened this issue 2 years ago • 6 comments

What this PR does / why we need it: Builds eraser w/ windows target

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged): Fixes #169

Special notes for your reviewer:

vyta avatar May 18 '22 17:05 vyta

Looks like the e2e test job timed out. May we increase timeout duration and rerun?

// @helayoty @sozercan

vyta avatar May 18 '22 18:05 vyta

@pmengelbert is this due to intermittent failure?

sozercan avatar May 18 '22 19:05 sozercan

@sozercan yes, this is why I reopened the issue. It's been difficult to reproduce, so I'll add these logs to the issue tracking intermittent failures @vyta

pmengelbert avatar May 18 '22 21:05 pmengelbert

The test timed out twice in a row. It may actually be related to the changes, though I don't know why.

pmengelbert avatar May 18 '22 21:05 pmengelbert

I think I may know the issue, working on the fix. h/o thanks!

vyta avatar May 18 '22 21:05 vyta

/hold - this needs a discussion on how to handle windows nodes/images since we can't scan them

sozercan avatar Jun 30 '22 16:06 sozercan

Closing this for now since we don't support Windows at this time due to no scanner available.

sozercan avatar Jan 30 '23 19:01 sozercan