jsTag
jsTag copied to clipboard
W3 valid demo with fallback to html input elements
In reference to this issue: https://github.com/eranhirs/jsTag/issues/31
Allowed use of html inputs so it can pass w3 validation:
<label for="tags">Tags</label>
<input id="tags" type="text" placeholder="Enter tags (separated by commas)" class="js-tag" />
Thank you for your contribution
- Please remove index.html (if you want to change it you need to compare against the 'gh-pages' branch)
- Please update the version in package.json & bower.json to 0.3.8
Please remove replace: true
since it might break existing applications.
Plus, it's normal to have a custom tag in Web Components & replace
is deprecated
See this stackoverflow question regarding replace: 'true' for more information
An update:
- remove index.html, shouldn't there be a demo somewhere in the repo of how to use? not just on gh-pages?
- update the version, done
- remove replace: true, it won't really work without replace, as the original element is an input. This gets replaced by the custom input. The only way it could work is to have a wrapper around every input with the js-tag class. Not a great solution. Replace:true is much cleaner and seems to be supported still?
- in addition i've add a hidden input contained the final result of all tags inputted: This is useful for normal form POST functions which need the tags in an html format
- I don't see why we need index.html inside the master branch
- I stand by my opinion about
replace: true
, it sounds to me like the W3 validator is outdated.