equo-ide icon indicating copy to clipboard operation
equo-ide copied to clipboard

Please support ''file' URL scheme

Open dhakehurst opened this issue 2 years ago • 3 comments

To get around issues with proxies, credentials etc, I download some p2 repos and install locally.

old p2AsMaven supported file urls for repos.

this new p2deps does not :-(

Caused by: java.lang.IllegalArgumentException: Expected URL scheme 'http' or 'https' but was 'file'
	at okhttp3.HttpUrl$Builder.parse$okhttp(HttpUrl.kt:1254)
	at okhttp3.HttpUrl$Companion.get(HttpUrl.kt:1634)
	at okhttp3.Request$Builder.url(Request.kt:184)
	at dev.equo.solstice.p2.P2Client.buildRequest(P2Client.java:146)

dhakehurst avatar Sep 01 '23 06:09 dhakehurst

Happy to take a PR for this.

nedtwigg avatar Sep 01 '23 13:09 nedtwigg

I had a look at doing it, but the issue seems to be in a library...so a bigger change than I can tackle, sorry

On Fri, 1 Sept 2023 at 15:42, Ned Twigg @.***> wrote:

Happy to take a PR for this.

— Reply to this email directly, view it on GitHub https://github.com/equodev/equo-ide/issues/165#issuecomment-1702770296, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABK3WZKPRUTIQKI6HDP3WB3XYHQ4DANCNFSM6AAAAAA4HC4CYU . You are receiving this because you authored the thread.Message ID: @.***>

dhakehurst avatar Sep 01 '23 14:09 dhakehurst

Yes, this is useful, and I've had the urge many times to desire it to read from a file so as to avoid having to build a server proxy to just forward locally.

y1yang0 avatar Sep 14 '23 02:09 y1yang0