equo-ide icon indicating copy to clipboard operation
equo-ide copied to clipboard
verified publisher icon equodev

Support HTTPS proxies and authentication

Open fullben opened this issue 2 years ago • 2 comments

Does this plugin support authentication with the remote it is trying to acquire dependencies from?

fullben avatar May 12 '23 09:05 fullben

It does not currently, but that could be added. HTTP clients are created in two places:

  1. for downloading p2 metadata https://github.com/equodev/equo-ide/blob/7606ceeb09531648df9be1b1b09700e55eb81174/solstice/src/main/java/dev/equo/solstice/p2/P2Client.java#L57-L63

  2. for downloading the actual jars https://github.com/equodev/equo-ide/blob/7606ceeb09531648df9be1b1b09700e55eb81174/solstice/src/main/java/dev/equo/solstice/p2/JarCache.java#L25-L26

Happy to merge a PR which adds auth support. Ideally we would copy whatever environment variables Eclipse p2 and Tycho are currently using for this, not sure how they handle it.

nedtwigg avatar May 16 '23 04:05 nedtwigg

Landed via spotless-gradle-plugin and having an interest in this functionality.

Proxy doesn't seem to be an issue as standard java proxy properties (e.g. http.proxyHost...) are honored but we are required to mirror the eclipse p2 repository from a central artifactory server requiring authentication. Effectively this currently prevents us from using newer spotless versions :-|

lkoe avatar Sep 05 '23 08:09 lkoe