Tomas Valent

Results 36 comments of Tomas Valent

do guys want me to rewrite this to if statements ? or is the exception capturing ok ?

🤔 wait a minute, now I'm re-reading @brenogazzola [comment](https://github.com/rails/propshaft/pull/94#issuecomment-1134633497) ...hmm I'm not sure about the prod but this solved the dev isuue 🤔 screen recording 📹 👇 https://user-images.githubusercontent.com/721990/210008614-65a9d72f-f621-4145-b065-22848c9bee3d.mov

@brenogazzola Ok took me a while to realise what's happening: * yes application-xxxxxxxx.css digest don't change * yes I agree theoretically it should (as digest is calculated from content and...

one more thing - during testing the above I've stumbled upon an edegecase: My PR proposes the no-store header by default for Development env(therefor no such issue as #90) 👍....

I think the issue is with the digested `application.css` not being notified that there was a change in `my-custom.css` that means [css_asset_urls compiler](https://github.com/rails/propshaft/blob/e6a6fe84727e1468474f07ebf1d407ec0f9a1b97/lib/propshaft/compilers/css_asset_urls.rb#L29) never get's triggered when change happens in...

> So it seems that somewhere on your load paths there is another my-custom.css, and that's the file that Propshaft is using. I've double checked that and seems no `my-custom.css`...

I would have to write really long comment to fully explain the reason for the issue in detail. Therefore I've created screencast to better explain it -> https://youtu.be/SoT9quSjous it's worth...

more I think about it more I realize the best way how to fix this is to avoid `@import("whatever.css")` and rather explicitly load CSS files from within ``: ```erb Myapp...

I had similar situation with bootstrap-icons.css which content is : ``` @font-face { font-family: "bootstrap-icons"; src: url("/fonts/bootstrap-icons.woff2?524846017b983fc8ded9325d94ed40f3") format("woff2"), url("/fonts/bootstrap-icons.woff?524846017b983fc8ded9325d94ed40f3") format("woff"); } ``` but was converted to `bootstrap-icons-7cf2f17964d150413c499c4ebee2e8cafb5d9bca.css`: ``` @font-face {...

...and I've just tested that by "Disable cache (while DevTools is open)" I've also solved the original issue with `@import` so no PR that would track File.mtime needed But it...