webviz-core-components icon indicating copy to clipboard operation
webviz-core-components copied to clipboard

Bump to react 18 and move to mui

Open w1nklr opened this issue 2 years ago • 2 comments

Bumps react from 16.14.0 to 18.2.0. Bumps react-dom from 16.14.0 to 18.2.0. Remove react-test-renderer.

Move from @material-ui to @mui 5.13.7.

Set both react and @mui packages as peer dependencies.

Bump storybook/* from 6.4.18 to 6.5.16.

w1nklr avatar Aug 10 '23 16:08 w1nklr

Support for React 18 is an experimental feature in Dash and has to be explicitly activated. Default it uses React 16.

Use React version 18.2 · Issue #2254 · plotly/dash (github.com)

I'm skeptical to adding this experimental feature to our production code.

Can this PR wait? Alternatively can we make sure the code is backwards compatible with 16? E.g. not use createRoot?

HansKallekleiv avatar Aug 15 '23 08:08 HansKallekleiv

Support for React 18 is an experimental feature in Dash and has to be explicitly activated. Default it uses React 16.

Use React version 18.2 · Issue #2254 · plotly/dash (github.com)

I'm skeptical to adding this experimental feature to our production code.

Can this PR wait? Alternatively can we make sure the code is backwards compatible with 16? E.g. not use createRoot?

OK, we can postpone this PR. The move to mui 5 does break compatibility with react 16, not only the move to createRoot. :/

w1nklr avatar Aug 17 '23 07:08 w1nklr

Replaced by #302

HansKallekleiv avatar Dec 19 '24 15:12 HansKallekleiv