radix-platform icon indicating copy to clipboard operation
radix-platform copied to clipboard

Always close firewall in all repos, even if workflow is cancelled

Open Richard87 opened this issue 11 months ago • 0 comments

protip from @sondresjolyst :D

We shoud use always() Instead of !cancelled() when closing firewalls https://github.com/equinor/radix-platform/blob/198d1013778d21fab3ea0315f863a1df8924dac6/.github/workflows/aksplan.yaml#L112

Current:

if: ${{ steps.update_firewall.outcome == 'success' && !cancelled()}} # Always run this step even if previous step failed

New

if: ${{ always() && steps.update_firewall.outcome == 'success' }}

Richard87 avatar Jan 27 '25 12:01 Richard87