radix-platform
radix-platform copied to clipboard
Always close firewall in all repos, even if workflow is cancelled
protip from @sondresjolyst :D
We shoud use always() Instead of !cancelled() when closing firewalls
https://github.com/equinor/radix-platform/blob/198d1013778d21fab3ea0315f863a1df8924dac6/.github/workflows/aksplan.yaml#L112
Current:
if: ${{ steps.update_firewall.outcome == 'success' && !cancelled()}} # Always run this step even if previous step failed
New
if: ${{ always() && steps.update_firewall.outcome == 'success' }}