ert icon indicating copy to clipboard operation
ert copied to clipboard

Add basic validations to ForwardModelStepPlugin such as executable exists

Open jonathan-eq opened this issue 5 months ago • 0 comments

What happened? (You can include a screenshot if it helps explain)

A user can create a ForwardModelStepPlugin to use in Ert with a bad path to an executable, and this will not be validated before it blows up mid run. Discuss whether we should add this validation or not, or whether this is Ert's responsibility in the ForwardModelStepPlugin constructor, or the FM implementor's responsibility through the ForwardModelStepPlugin.validate_pre_experiment(...) api.

It should at most be a warning, because there can be forward models preceding this one that creates the necessary files/executables.

See previous discussion under PR: https://github.com/equinor/ert/pull/8735

What did you expect to happen?

Warning if a non existent executable is provided, with a explanation that it might be ok

steps to reproduce

Create a forward model step plugin with a bad executable.

Environment where bug has been observed

  • [ ] python 3.8
  • [ ] python 3.9
  • [ ] python 3.10
  • [ ] python 3.11
  • [ ] python 3.12
  • [ ] macosx
  • [ ] rhel7
  • [ ] rhel8
  • [ ] local queue
  • [ ] lsf queue
  • [ ] slurm queue
  • [ ] openPBS queue
  • [ ] used flag --enable-scheduler

jonathan-eq avatar Sep 24 '24 07:09 jonathan-eq