ert icon indicating copy to clipboard operation
ert copied to clipboard

Fix get_number_of_existing_runpaths()

Open frode-aarstad opened this issue 1 year ago • 1 comments

Issue Resolves #8276

Approach Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • [ ] PR title captures the intent of the changes, and is fitting for release notes.
  • [ ] Added appropriate release note label
  • [ ] Commit history is consistent and clean, in line with the contribution guidelines.
  • [ ] Make sure tests pass locally (after every commit!)

When applicable

  • [ ] When there are user facing changes: Updated documentation
  • [ ] New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • [ ] Large PR: Prepare changes in small commits for more convenient review
  • [ ] Bug fix: Add regression test for the bug
  • [ ] Bug fix: Create Backport PR to latest release

frode-aarstad avatar Jul 04 '24 06:07 frode-aarstad

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.92%. Comparing base (6be9385) to head (d710c60).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8297      +/-   ##
==========================================
- Coverage   86.92%   86.92%   -0.01%     
==========================================
  Files         375      375              
  Lines       23523    23524       +1     
  Branches      624      626       +2     
==========================================
  Hits        20448    20448              
+ Misses       2999     2997       -2     
- Partials       76       79       +3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jul 04 '24 06:07 codecov-commenter

image

I'm now getting: 100 out of 100 realizations are running in existing runpaths. This look alright I think. However, the Experiment name input is "red" indicating a duplicate experiment name, which I don't think makes sense since we are re-running in an existing experiment. Another issue perhaps?

dafeda avatar Jul 29 '24 10:07 dafeda

Experiment name input is "red" indicating a duplicate experiment name, which I don't think makes sense since we are re-running in an existing experiment. Another issue perhaps?

This is another issue. I will create one

frode-aarstad avatar Aug 05 '24 06:08 frode-aarstad