ert icon indicating copy to clipboard operation
ert copied to clipboard

Add plot for observations

Open frode-aarstad opened this issue 10 months ago • 1 comments

Issue Resolves #7509

Approach Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • [ ] PR title captures the intent of the changes, and is fitting for release notes.
  • [ ] Added appropriate release note label
  • [ ] Commit history is consistent and clean, in line with the contribution guidelines.
  • [ ] Make sure tests pass locally (after every commit!)

When applicable

  • [ ] When there are user facing changes: Updated documentation
  • [ ] New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • [ ] Large PR: Prepare changes in small commits for more convenient review
  • [ ] Bug fix: Add regression test for the bug
  • [ ] Bug fix: Create Backport PR to latest release

frode-aarstad avatar Apr 09 '24 10:04 frode-aarstad

bilde

frode-aarstad avatar Apr 09 '24 10:04 frode-aarstad

Not sure I understand the plot. From my understanding, there is only one observation and one or more responses. What does the left-hand side plot show?

dafeda avatar Apr 18 '24 07:04 dafeda

Not sure I understand the plot. From my understanding, there is only one observation and one or more responses. What does the left-hand side plot show?

The left column is the observation, now we plot one for each realization but we should only plot one. The right is the responses one for each realization. So in the above image there are 25 responses.

frode-aarstad avatar Apr 18 '24 09:04 frode-aarstad

Not sure I understand the plot. From my understanding, there is only one observation and one or more responses. What does the left-hand side plot show?

The left column is the observation, now we plot one for each realization but we should only plot one. The right is the responses one for each realization. So in the above image there are 25 responses.

Yes, only plot one and add error-bars right?

dafeda avatar Apr 18 '24 10:04 dafeda

Now left column is observation with +-std dev image

frode-aarstad avatar Apr 22 '24 10:04 frode-aarstad

Codecov Report

Attention: Patch coverage is 54.09836% with 56 lines in your changes are missing coverage. Please review.

Project coverage is 85.54%. Comparing base (50a4421) to head (7567360). Report is 4 commits behind head on main.

Files Patch % Lines
src/ert/gui/ertwidgets/storage_info_widget.py 48.59% 55 Missing :warning:
src/ert/gui/ertwidgets/storage_widget.py 90.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7604      +/-   ##
==========================================
- Coverage   85.74%   85.54%   -0.21%     
==========================================
  Files         382      382              
  Lines       23272    23364      +92     
  Branches      893      877      -16     
==========================================
+ Hits        19955    19987      +32     
- Misses       3210     3263      +53     
- Partials      107      114       +7     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Apr 22 '24 11:04 codecov-commenter

Now left column is observation with +-std dev image

image

A box plot consists of these elements. What does the blue box signify when we only have one observation? I think we may want to just show an errorbar for the observation.

dafeda avatar Apr 23 '24 07:04 dafeda

image

frode-aarstad avatar Apr 24 '24 08:04 frode-aarstad