ert icon indicating copy to clipboard operation
ert copied to clipboard

Reflect failed realizations after ert restart

Open dafeda opened this issue 11 months ago • 1 comments

Issue Resolves #7505

  • [ ] PR title captures the intent of the changes, and is fitting for release notes.
  • [ ] Added appropriate release note label
  • [ ] Commit history is consistent and clean, in line with the contribution guidelines.
  • [ ] Make sure tests pass locally (after every commit!)

When applicable

  • [ ] When there are user facing changes: Updated documentation
  • [ ] New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • [ ] Large PR: Prepare changes in small commits for more convenient review
  • [ ] Bug fix: Add regression test for the bug
  • [ ] Bug fix: Create Backport PR to latest release

dafeda avatar Mar 22 '24 12:03 dafeda

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.73%. Comparing base (4496033) to head (ba9f7dd).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7514      +/-   ##
==========================================
- Coverage   84.79%   84.73%   -0.07%     
==========================================
  Files         383      383              
  Lines       23309    23316       +7     
  Branches      890      881       -9     
==========================================
- Hits        19766    19757       -9     
- Misses       3431     3452      +21     
+ Partials      112      107       -5     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Mar 22 '24 13:03 codecov-commenter

Giving up on writing a test for this.

Have manually tested and "Evaluate ensemble" looks like this after closing and re-opening ert:

image

ES-MDA also shows the correct active realizations:

image

And IES:

image

dafeda avatar Apr 12 '24 08:04 dafeda