ert icon indicating copy to clipboard operation
ert copied to clipboard

Add logging to map surface usage

Open aronhoyer opened this issue 11 months ago • 3 comments

Issue Resolves #6997

  • [x] PR title captures the intent of the changes, and is fitting for release notes.
  • [x] Added appropriate release note label
  • [x] Commit history is consistent and clean, in line with the contribution guidelines.
  • [ ] ~~Make sure tests pass locally (after every commit!)~~

When applicable

  • [ ] ~~When there are user facing changes: Updated documentation~~
  • [ ] ~~New behavior or changes to existing untested code: Ensured that unit tests are added (See [Ground Rules]~~(https://github.com/equinor/ert/blob/main/CONTRIBUTING.md#ground-rules)).
  • [ ] ~~Large PR: Prepare changes in small commits for more convenient review~~
  • [ ] ~~Bug fix: Add regression test for the bug~~
  • [ ] ~~Bug fix: Create Backport PR to latest release~~

aronhoyer avatar Feb 29 '24 08:02 aronhoyer

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.42%. Comparing base (5faa55b) to head (69bb89a). Report is 313 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7300      +/-   ##
==========================================
- Coverage   85.46%   85.42%   -0.05%     
==========================================
  Files         383      383              
  Lines       22818    23528     +710     
  Branches      933      880      -53     
==========================================
+ Hits        19502    20099     +597     
- Misses       3201     3315     +114     
+ Partials      115      114       -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Feb 29 '24 09:02 codecov-commenter

What's a good test to run to check that this logs correctly? Don't need to add an assert I think, I just want to check it manually once.

dafeda avatar Mar 04 '24 07:03 dafeda

@dafeda well I suppose you'll first need a .irap file and set the SURFACE config key. I'm not sure how you'd get your hands on a .irap file, though.

aronhoyer avatar Mar 04 '24 08:03 aronhoyer