equinor
Clarify outlier/low variability detection warnings ES
Codecov Report
Attention: Patch coverage is 97.72727% with 1 lines in your changes are missing coverage. Please review.
Project coverage is 85.23%. Comparing base (
5e5ed6f) to head (ee3d710). Report is 2 commits behind head on main.
| Files | Patch % | Lines |
|---|---|---|
| src/ert/analysis/_es_update.py | 96.87% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #6512 +/- ##
==========================================
+ Coverage 85.22% 85.23% +0.01%
==========================================
Files 384 384
Lines 22907 22939 +32
Branches 881 883 +2
==========================================
+ Hits 19522 19553 +31
- Misses 3272 3275 +3
+ Partials 113 111 -2
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Note that some of this information is also available in the update snapshot: https://github.com/equinor/ert/blob/9f7ac75b4a8a6285659bb1ba641c14a2f9b79ec7/src/ert/analysis/_es_update.py#L60-L67 which is written out after an update, so might make sense to gather this information more.
Note that some of this information is also available in the update snapshot:
https://github.com/equinor/ert/blob/9f7ac75b4a8a6285659bb1ba641c14a2f9b79ec7/src/ert/analysis/_es_update.py#L60-L67
which is written out after an update, so might make sense to gather this information more.
I see, will try to gather it there, I think it also then makes sense to silence the original warning, ref this slack convo where user gets many of these messages and wonders why they were disabled.
Would be great to add this in the update snapshot instead of in the log, so we get a column there with the index.
Closing this as the original issue has been fixed: https://github.com/equinor/ert/issues/6262
