ert
ert copied to clipboard
Remove bunch of stuff from ensemble config
Please consider the commit messages for explanations of what's going on, and justifications for the removals.
I will / intend to fixup / squash many of the commits before merging, they are mostly left isolated to make the review process easier.
Pre review checklist
- [x] Added appropriate release note label
- [x] PR title captures the intent of the changes, and is fitting for release notes.
- [ ] Commit history is consistent and clean, in line with the contribution guidelines.
Adding labels helps the maintainers when writing release notes. This is the list of release note labels.
Codecov Report
Merging #4075 (a0fcd6e) into main (9d35798) will increase coverage by
0.15%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## main #4075 +/- ##
==========================================
+ Coverage 57.70% 57.86% +0.15%
==========================================
Files 510 510
Lines 38309 38135 -174
Branches 3433 3398 -35
==========================================
- Hits 22107 22065 -42
+ Misses 15327 15203 -124
+ Partials 875 867 -8
Impacted Files | Coverage Δ | |
---|---|---|
src/clib/lib/enkf/config_keys.cpp | 0.88% <ø> (+0.01%) |
:arrow_up: |
src/clib/lib/enkf/enkf_config_node.cpp | 42.94% <0.00%> (-0.76%) |
:arrow_down: |
src/clib/lib/enkf/enkf_node.cpp | 1.36% <ø> (+<0.01%) |
:arrow_up: |
src/clib/lib/enkf/gen_data.cpp | 32.60% <ø> (+6.29%) |
:arrow_up: |
src/clib/lib/enkf/gen_data_config.cpp | 60.89% <ø> (+11.61%) |
:arrow_up: |
...rc/ert/_c_wrappers/enkf/config/enkf_config_node.py | 78.00% <ø> (ø) |
|
src/ert/_c_wrappers/enkf/config/gen_data_config.py | 82.14% <ø> (+0.98%) |
:arrow_up: |
src/ert/_c_wrappers/enkf/data/gen_data.py | 67.56% <ø> (+0.06%) |
:arrow_up: |
src/ert/_c_wrappers/enkf/ensemble_config.py | 91.33% <ø> (ø) |
|
src/ert/_c_wrappers/enkf/enkf_fs_manager.py | 86.44% <0.00%> (-5.87%) |
:arrow_down: |
... and 13 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
if you should happen to review and want to merge during my absence, which i sincerely hope, feel free to squash all the commits, I think this can just be bundled up as remove unused code - maybe keep the bit i wrote about the export function only being used (according to both code and comment) for the field type, if you feel like it.
Could the naming of this PR be updated to be a bit more informative for the release notes?
it is done!