ert icon indicating copy to clipboard operation
ert copied to clipboard

Make sure that processing reporter.event_queue does not yield ConnectionError

Open xjules opened this issue 2 years ago • 4 comments

Issue Make sure that processing reporter.event_queue does not yield ConnectionError.

Approach We don't yield ConnectionError, but instead keep processing next events in the queue. If the Finish event is received, we setup the timer (60 seconds), which when reached will automatically stop the publisher thread and exit.

Pre review checklist

  • [x] Added appropriate release note label
  • [x] PR title captures the intent of the changes, and is fitting for release notes.
  • [x] Commit history is consistent and clean, in line with the contribution guidelines.

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

xjules avatar Oct 05 '22 13:10 xjules

Codecov Report

Merging #4001 (267ddfb) into main (44c1a77) will increase coverage by 0.00%. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4001   +/-   ##
=======================================
  Coverage   57.72%   57.73%           
=======================================
  Files         510      510           
  Lines       38315    38304   -11     
  Branches     3431     3431           
=======================================
- Hits        22117    22114    -3     
+ Misses      15324    15315    -9     
- Partials      874      875    +1     
Impacted Files Coverage Δ
src/ert/ensemble_evaluator/builder/_prefect.py 64.64% <0.00%> (-1.02%) :arrow_down:
src/clib/lib/res_util/block_fs.cpp 66.66% <0.00%> (ø)
src/ert/_c_wrappers/enkf/enkf_main.py 98.40% <0.00%> (+3.74%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Oct 05 '22 13:10 codecov-commenter

What do you think?: def _publish_event(self) -> def _event_publisher(self)

As this is a function that is designed to continuously publish events. Not a biggie, just a small suggestion..

lars-petter-hauge avatar Oct 06 '22 06:10 lars-petter-hauge

Thanks for the PR, just had some small comments/questions :)

lars-petter-hauge avatar Oct 06 '22 06:10 lars-petter-hauge

Could you please rephrase the commit message a bit? ("but" -> "by"?, should also be less than 80 chars or something, otherwise it's wrapped..)

lars-petter-hauge avatar Oct 10 '22 14:10 lars-petter-hauge

What do you think?: def _publish_event(self) -> def _event_publisher(self)

As this is a function that is designed to continuously publish events. Not a biggie, just a small suggestion..

We might do the change in another PR as it touches all reporters

xjules avatar Oct 26 '22 07:10 xjules

Should this be backported to version 4.1?

sondreso avatar Nov 04 '22 15:11 sondreso