ert icon indicating copy to clipboard operation
ert copied to clipboard

Try running some of the pytests with -n X

Open frode-aarstad opened this issue 2 years ago • 3 comments

Issue Resolves #my_issue

Approach Short description of the approach

Pre review checklist

  • [ ] Added appropriate release note label
  • [ ] PR title captures the intent of the changes, and is fitting for release notes.
  • [ ] Commit history is consistent and clean, in line with the contribution guidelines.

Adding labels helps the maintainers when writing release notes. This is the list of release note labels.

frode-aarstad avatar Sep 07 '22 08:09 frode-aarstad

Codecov Report

Merging #3875 (21be90a) into main (52ce69c) will increase coverage by 0.01%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3875      +/-   ##
==========================================
+ Coverage   63.74%   63.75%   +0.01%     
==========================================
  Files         588      588              
  Lines       43841    43841              
  Branches     3786     3786              
==========================================
+ Hits        27946    27951       +5     
+ Misses      14772    14767       -5     
  Partials     1123     1123              
Impacted Files Coverage Δ
src/ert/gui/model/snapshot.py 88.06% <0.00%> (+0.32%) :arrow_up:
src/ert/data/record/_transformation.py 89.04% <0.00%> (+0.47%) :arrow_up:
src/ert/job_runner/job.py 72.78% <0.00%> (+2.04%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Sep 07 '22 09:09 codecov-commenter

github action runners supposedly only have 2 cores: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners

eivindjahren avatar Sep 07 '22 11:09 eivindjahren

Some results:

Github actions

For Python coverage / Python Coverage (ert) the time went from 27 min to 16 min with -n 2 (two cores) and for Python coverage / Python Coverage (res) (pull_request) the time went from 16 min to 11 min.

Note that the time for these actions varies quite a bit but it seems like running in parallel on two cores has a positive effect on running time.

Jenkins

Adding -n 4 to the x-ert-ERT job caused several tests to fail. Need to investigate further why the tests failed

frode-aarstad avatar Sep 07 '22 12:09 frode-aarstad

Will close this as there have been quite a few changes to the test running. Feel free to reopen if you pick it up again.

oyvindeide avatar Nov 15 '22 15:11 oyvindeide