ert icon indicating copy to clipboard operation
ert copied to clipboard

Make asyncio usage compatible with Python 3.10 (remove deprecation warning)

Open lars-petter-hauge opened this issue 2 years ago • 1 comments

The get_event_loop method is deprecated in Python 3.10 (https://docs.python.org/3/library/asyncio-eventloop.html#asyncio.get_event_loop). Refactor our usage of asyncio in ert to be compatible with future releases of asyncio

lars-petter-hauge avatar Apr 07 '22 08:04 lars-petter-hauge

Deprecation plan has been changed, this is deprecated from Python 3.12.

The call is currently only being used in https://github.com/equinor/ert/blob/01c1f9a9ffcbe663e2e9c79052ba4ff18e74562e/src/ert/async_utils.py#L20C1-L25C40

berland avatar Apr 11 '24 11:04 berland

The RunTimeError caught in this code is triggered by everest's pytest. Erts own tests will pass without the try clause in async_utils.py.

berland avatar Aug 07 '24 07:08 berland

The RunTimeError caught in this code is triggered by everest's pytest. Erts own tests will pass without the try clause in async_utils.py.

Not perfectly true, Ert's tests on its everest interface (batch simulation) will fail.

berland avatar Aug 07 '24 09:08 berland

Everest gui tested manually to work fine with this.

berland avatar Aug 07 '24 10:08 berland