ert icon indicating copy to clipboard operation
ert copied to clipboard

Re-introduce public and private ip-getting, add LSF test

Open flikka opened this issue 2 months ago • 2 comments

Issue Resolves #12236

Approach Revert back the IP selection with private and public, but use public by default This paves way for a configurable site-config variable.

Adds a test that can be run on LSF queue cluster, that will fail (timeout) if network used is not reachable

  • [ ] PR title captures the intent of the changes, and is fitting for release notes.
  • [ ] Added appropriate release note label
  • [ ] Commit history is consistent and clean, in line with the contribution guidelines.
  • [ ] Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • [ ] When there are user facing changes: Updated documentation
  • [ ] New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • [ ] Large PR: Prepare changes in small commits for more convenient review
  • [ ] Bug fix: Add regression test for the bug
  • [ ] Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

flikka avatar Nov 12 '25 08:11 flikka

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 90.63%. Comparing base (37cea39) to head (248baa0). :warning: Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12269      +/-   ##
==========================================
- Coverage   90.64%   90.63%   -0.01%     
==========================================
  Files         434      433       -1     
  Lines       29015    29028      +13     
==========================================
+ Hits        26300    26310      +10     
- Misses       2715     2718       +3     
Flag Coverage Δ
cli-tests 37.77% <12.50%> (-0.03%) :arrow_down:
gui-tests 69.15% <12.50%> (+0.03%) :arrow_up:
performance-and-unit-tests 74.02% <100.00%> (-0.03%) :arrow_down:
test 38.59% <12.50%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Nov 12 '25 08:11 codecov-commenter

CodSpeed Performance Report

Merging #12269 will not alter performance

Comparing flikka:test_zmq_network_ok (248baa0) with main (efe13e8)

Summary

✅ 22 untouched

codspeed-hq[bot] avatar Nov 12 '25 09:11 codspeed-hq[bot]