design-system icon indicating copy to clipboard operation
design-system copied to clipboard

Convert Side sheet to Variants

Open benkeq opened this issue 4 years ago • 7 comments

Blocked by #918 and #928

Variants in Figma

  • [x] Add documentation link
  • [ ] Test to see if it's possible to solve #263 with variants.

Variant properties: Dark theme: True/False Width: Small/Medium/Large/X Large

benkeq avatar Oct 28 '20 08:10 benkeq

Ready for review @benkeq Didn't have enough informations to solve #263. Wants a user to use all types of H in headlines?

lucasveil avatar Nov 19 '20 10:11 lucasveil

Variants are ready for review @benkeq Was unsure how to deal with components that looks the same in single / multi. Also, didn't find any related documentation in the storefront

lucasveil avatar Nov 19 '20 10:11 lucasveil

Since you've got a lot of tasks, and the rest is for onboarding, do you want me to take this? @lucasveil

benkeq avatar Nov 24 '20 12:11 benkeq

Go for it @benkeq :)

lucasveil avatar Nov 24 '20 14:11 lucasveil

Waiting for typography meeting regarding #263

benkeq avatar Nov 25 '20 07:11 benkeq

blocked by #918

mimarz avatar Nov 27 '20 08:11 mimarz

Since it's blocked by #918 and #928, this will probably not be solved until late December, or next year. I'm removing myself as assignee.

I think the best solution to this issue and #263 is to create new variants with other heading sizes. This will result in 8*x where x is how many different sizes we would like to offer. If all heading sizes are made available, we would have 56 variants, but I think it's better to choose a few.

benkeq avatar Nov 30 '20 10:11 benkeq

Not relevant anymore

nilsml avatar May 04 '23 11:05 nilsml