design-system
design-system copied to clipboard
Convert Side sheet to Variants
Blocked by #918 and #928
- [x] Add documentation link
- [ ] Test to see if it's possible to solve #263 with variants.
Variant properties:
Dark theme: True
/False
Width: Small
/Medium
/Large
/X Large
Ready for review @benkeq Didn't have enough informations to solve #263. Wants a user to use all types of H in headlines?
Variants are ready for review @benkeq Was unsure how to deal with components that looks the same in single / multi. Also, didn't find any related documentation in the storefront
Since you've got a lot of tasks, and the rest is for onboarding, do you want me to take this? @lucasveil
Go for it @benkeq :)
Waiting for typography meeting regarding #263
blocked by #918
Since it's blocked by #918 and #928, this will probably not be solved until late December, or next year. I'm removing myself as assignee.
I think the best solution to this issue and #263 is to create new variants with other heading sizes. This will result in 8*x where x is how many different sizes we would like to offer. If all heading sizes are made available, we would have 56 variants, but I think it's better to choose a few.
Not relevant anymore