neovim-qt icon indicating copy to clipboard operation
neovim-qt copied to clipboard

Hard-Coded NeovimConnector Timeout

Open jgehrig opened this issue 3 years ago • 1 comments

See: https://github.com/equalsraf/neovim-qt/blob/84721b6d5935bbd1b747e5d0aae31ba046883ded/src/gui/shell.cpp#L291-L292

This value should be parameterized.

jgehrig avatar Jul 11 '21 19:07 jgehrig

This also may be a good time to evaluate the default value for ConnectorInitArgs

See src/gui/app.cpp from #848:

struct ConnectorInitArgs
{
	enum class Type
	{
		Embed,
		Server,
		Spawn,
		Default
	};

	const Type type{ Type ::Default };
	const int timeout{ 10000 }; // <-- Is this a sane default value?
	...

jgehrig avatar Jul 12 '21 15:07 jgehrig