Ryan Hunt

Results 167 comments of Ryan Hunt

That's fine with me. I think the JS-API spec text needs to be updated to clarify this too, as the plain reading of it now would permit `-0`. SpiderMonkey will...

> So I think we should at least make the "navigate back" interaction work, maybe also the "Press Esc" interaction. For navigating back to un-maximize the source view, the source...

I've updated the patch with new messages, new SVG icons for minimize/maximise (from font awesome, [license here I think](https://fontawesome.com/license/free)), escape closes fullscreen, and using the history back button closes fullscreen.

I tried out both of the icons, I'm not sure which I prefer. I also moved the icon to be next to close button, as I think it logically goes...

Friendly review ping @canova

Thanks for this proposal, good to see a concrete idea in this space finally. Unordered thoughts: 1. 'can JIT' flag on memory types - I'm a little skeptical this would...

@rossberg > Rather, I think this feature is a clear example of something that needs profile support. Not sure why it would justify an ad-hoc feature detection mechanism more than...

@titzer Yeah, that is the status quo for wasm feature tests on the web. The unfortunate thing is that the build combinations users need to support grows really quick. You...

Thanks for proposing this. I think overall this makes sense to me. >All of the instructions will be similar to the load/store memory instructions and take an immediate memarg {offset...