EQcorrscan
EQcorrscan copied to clipboard
Check full SEED ID when comparing picks and waveforms
What does this PR do?
Clean take-over from #391
Uses full SEED information (adds network and location) when comparing e.g. pick.waveform_id and tr.stats in a number of functions. Mostly importantly template_gen, but may also include mag_calc and others.
Why was it initiated? Any relevant Issues?
#388
In situations where the desired template or trace contains unique picks with the same Station and Channel, but different location and/or Network codes (e.g. separate sensors in one borehole), current behavior does not differentiate between them.
Assorted to-dos:
- [ ]
utils.correlate
funcs all returncccs
,no_chans
, andchans
.chans
only includes station.channel, which then gets passed toDetection
objects. Allow for full seed chans inDetection
- [ ] Track down all the possible effects of using a full seed id
chans
attribute forDetection
objects...could touch quite a lot... - [ ] Lag calc
UsedChannel
only uses station.channel. Allow for full seed option. - [ ] Add depreciation warnings
- [ ] Add docs "Help" page for adding full SEED IDs to
Pick
objects and link from depreciation warning.
PR Checklist
- [x]
develop
base branch selected? - [x] This PR is not directly related to an existing issue (which has no PR yet).
- [ ] All tests still pass.
- [ ] Any new features or fixed regressions are be covered via new tests.
- [ ] Any new or changed features have are fully documented.
- [ ] Significant changes have been added to
CHANGES.md
. - [x] First time contributors have added your name to
CONTRIBUTORS.md
.
I think I captured all the relevant changes from #391 - @cjhopp let me know if you spot anything that is missing. Otherwise I will chug on with this.