Pete Walsh

Results 285 comments of Pete Walsh

Hi @SirWindfield, for your first question there is the [`freshness_lifetime`](https://docs.rs/cached-path/0.4.5/cached_path/struct.CacheBuilder.html#method.freshness_lifetime) option. For your second question, I don't think it would be too hard to have an async version behind a...

Hi @dduenker, this is expected given that the server doesn't provide an ETAG header. That said, you could use the [`freshness_lifetime`](https://docs.rs/cached-path/0.5.1/cached_path/struct.CacheBuilder.html#method.freshness_lifetime) setting to ensure the cache is periodically updated. Would...

> Is there any reason not to use the last-modified and cache-control headers? No reason, that's a great idea actually. It wouldn't be hard to implement.. we could just treat...

Great! Let me know if you have any questions

FYI it is possible to store an expiration time in the meta JSON file: https://github.com/epwalsh/rust-cached-path/blob/master/src/meta.rs#L20

Hey @eggyal, I would definitely accept a PR for this. I like the idea of using HTTP headers, so I think that should be the first priority. It would also...

@lynch-a I'm not aware of any workarounds yet :(

Updating your branch should fix the linting CI failures

Hey @olliemath, regarding CPU bound tasks, the short answer is you don't need to do anything special. The tokio executor should handle CPU bound tasks well enough. See https://github.com/rusty-celery/rusty-celery/pull/71 for...

@olliemath good to know. How many CPUs on the machine where you ran this?