Eric Pugh

@cpoerschke I'd love a review, I think this is ready!

> 19 / 26 files viewed > > I wonder if we could/should also put the assert versions in question on the 'forbidden list' e.g. https://github.com/apache/solr/tree/main/gradle/validation/forbidden-apis or in some other...

I gave it a stab of adding it to forbiddenapis, but didn't quite get it to work... There are *some* places that it's okay, like in the LTR module... May...

Thanks for approving the changes @uschindler! I'm waiting on @cpoerschke to finish her review, and the SolrJ-Zookeeper to get merged, and then I'll merge this one!

I've fixed the merge conflict, so I'd like to merge this PR this week, so then I can move on to the new plan of fixing the unit test warnings...

I tagged @madrob for this one, however it LGTM. I've been bit by this issue before, especially in Eclipse.

This is great, I've seen this noise output and always find it "alarming" to see!

Did you see the precommit failure on missing license header @tboeghk ?

One more request @tboeghk, it apears from JIRA that your patch would fix https://issues.apache.org/jira/browse/SOLR-14931 ???

Does anyone ever say "no, we don't need another test" ;-) I'd love one, partly because this whole space is kind of new for me, so it might help me...