Sebastian "Sebbie" Silbermann

Results 555 comments of Sebastian "Sebbie" Silbermann

Thank you for the bug report and detailed repro! It also reproduces in Canary and Experimental release channels. Keep in mind that this would only affect development since StrictMode has...

Doesn't this also issue this warning when you'd use `@testing-library/react-native`? Are they expected to catch this warning? Otherwise the warning is noise for `@testing-library/react-native` users since they're not using a...

It's a bit unfortunate that we never landed a deprecation warning. Instead of removing, can we throw in the entrypoint with a message pointing to the new package?

Needs to be adjusted to work for React 16.8. Currently throws with `Uncaught Error: Cannot read properties of undefined (reading 'firstContext')`

> If yes, then you can try adding test cases that will cover compatibility with previous versions of React? Problem is that the inspectedElement-test is broken. I quickly looked at...

Next.js hasn't caught up with the React version that supports this hook. You need to wait for a release of https://github.com/vercel/next.js/pull/64798 to use this hook.

@kassens It can now be landed cleanly. When you land it, would you take care of rolling it out at Meta?

Seems like various www tests are failing with these changes

This is a TypeScript limitation I believe. TS would also not refine the type if you put the condition in an function call which is was useMemo basically is.

We get the old `expect(allSchedulerTypes).toEqual([[null], [Suspender], [Suspender]]);` match once we start looking into `pendingUpdatersLaneMap` with ```diff diff --git a/packages/react-reconciler/src/__tests__/ReactUpdaters-test.internal.js b/packages/react-reconciler/src/__tests__/ReactUpdaters-test.internal.js index d518159ce8..b45f7e6259 100644 --- a/packages/react-reconciler/src/__tests__/ReactUpdaters-test.internal.js +++ b/packages/react-reconciler/src/__tests__/ReactUpdaters-test.internal.js @@ -45,10 +45,19...