Sebastian "Sebbie" Silbermann

Results 555 comments of Sebastian "Sebbie" Silbermann

Should I review this considering it's in draft and you said it's not ready yet?

Sure, sounds awesome. However, we usually wait and monitor adoption before bringing it into the org. Seems like it isn't even released yet.

We would need to extend https://github.com/testing-library/dom-testing-library/issues/1033 to query methods returned from `render`. For `screen` you can already use ```tsx import * as React from 'react'; import { render, screen }...

> For instance, jest uses @sinonjs/fake-timers under the hood, and yet it's not possible to use @sinonjs/fake-timers directly with testing-library. The reference to jest is not relevant here. We do...

> they would call domTestingLibrary.useFakeTimers() and pass in a timing adapter made for the library they want to use? That was my initial plan, yes. Not sure about the API...

> Can you talk a bit more about this? Is that work being tracked anywhere, in a separate issue maybe? It's not blocking this issue.

Thanks for the feedback To be clear: The query should return the `` not the `` as far as I understood [SVG title element](https://developer.mozilla.org/en-US/docs/Web/SVG/Element/title). It sounds like we should implement...

Just guessing here: `getByText("Close", selector: 'title')` and then walk up to the nearest SVG container or graphics element.

> @eps1lon any updates for this issue? PRs welcome for https://github.com/testing-library/dom-testing-library/issues/974#issuecomment-858028323

That implementation seems too clever. It breaks as soon as any of these names and nesting are valid HTML. Let's make it work first and then check if we need...