lms icon indicating copy to clipboard operation
lms copied to clipboard

Multi-discs albums appearing once for each disc in the album entries

Open awsms opened this issue 1 year ago • 3 comments

Screenshot from 2024-06-11 18-50-34 Screenshot from 2024-06-11 18-50-25 Screenshot from 2024-06-11 18-50-16

Folder structure:

The Dubliners - Complete Collection [FLAC]/
├── CD 1
├── CD 2
├── CD 3
└── CD 4

CD1 Track 1 tags:

  comments: 13
    comment[0]: ARTIST=The Dubliners
    comment[1]: TITLE=The Molly Maguires
    comment[2]: ALBUM=Complete Collection
    comment[3]: DATE=2006
    comment[4]: TRACKNUMBER=01
    comment[5]: GENRE=Celtic
    comment[6]: PERFORMER=The Dubliners
    comment[7]: COMPOSER=
    comment[8]: ALBUMARTIST=The Dubliners
    comment[9]: DISCNUMBER=1
    comment[10]: TOTALDISCS=4
    comment[11]: TOTALTRACKS=20
    comment[12]: COMMENT=

CD2 Track 1 tags:

  comments: 13
    comment[0]: ARTIST=The Dubliners
    comment[1]: TITLE=Free The People
    comment[2]: ALBUM=Complete Collection
    comment[3]: DATE=2009
    comment[4]: TRACKNUMBER=01
    comment[5]: GENRE=Celtic
    comment[6]: PERFORMER=The Dubliners
    comment[7]: COMPOSER=
    comment[8]: ALBUMARTIST=The Dubliners
    comment[9]: DISCNUMBER=2
    comment[10]: TOTALDISCS=4
    comment[11]: TOTALTRACKS=20
    comment[12]: COMMENT=

Is there anything wrong here, or that's expected behaviour? I found https://github.com/epoupon/lms/issues/6, which implies multi-disc albums are well supported on LMS.

awsms avatar Jun 11 '24 16:06 awsms

Hello, Sorry for late response. For now, the only reliable way to group these discs is to use a musicbrainz release id. If this tag is not present, only the files in the same directory are considered to be part of the same album (and if the name of the album is the same, of course)

epoupon avatar Jun 15 '24 14:06 epoupon

Mhh.. so LMS relies a LOT on MusicBrainz's metadata, as it's also the case for the dupechecker which simply checks a MB track id (and probably other things I haven't found yet). Shouldn't it be mentioned somewhere in the README? Because I pretty much assumed by reading it setting the same album tag & same album artist for files would group them (like it's the case with navidrome for ex.)

awsms avatar Jun 16 '24 14:06 awsms

Yes, it relies a lot on MB (and it is assumed). You are right, this should be better stated in the readme file. That being said, we can try to improve the fallback behavior to handle more use cases :)

epoupon avatar Jun 16 '24 14:06 epoupon

Hi again! So after pulling the docker image for the latest build, I did a force library rescan. However, I'm still seeing multi-discs albums as multiple albums instead. image

awsms avatar Sep 23 '24 11:09 awsms

Hello! What is the layout of the offending album?

epoupon avatar Sep 23 '24 12:09 epoupon

Exactly the same as in the OP, I haven't changed it since: Folder structure:

The Dubliners - Complete Collection [FLAC]/
├── CD 1
├── CD 2
├── CD 3
└── CD 4

CD1 Track 1 tags:

  comments: 13
    comment[0]: ARTIST=The Dubliners
    comment[1]: TITLE=The Molly Maguires
    comment[2]: ALBUM=Complete Collection
    comment[3]: DATE=2006
    comment[4]: TRACKNUMBER=01
    comment[5]: GENRE=Celtic
    comment[6]: PERFORMER=The Dubliners
    comment[7]: COMPOSER=
    comment[8]: ALBUMARTIST=The Dubliners
    comment[9]: DISCNUMBER=1
    comment[10]: TOTALDISCS=4
    comment[11]: TOTALTRACKS=20
    comment[12]: COMMENT=

CD2 Track 1 tags:

  comments: 13
    comment[0]: ARTIST=The Dubliners
    comment[1]: TITLE=Free The People
    comment[2]: ALBUM=Complete Collection
    comment[3]: DATE=2009
    comment[4]: TRACKNUMBER=01
    comment[5]: GENRE=Celtic
    comment[6]: PERFORMER=The Dubliners
    comment[7]: COMPOSER=
    comment[8]: ALBUMARTIST=The Dubliners
    comment[9]: DISCNUMBER=2
    comment[10]: TOTALDISCS=4
    comment[11]: TOTALTRACKS=20
    comment[12]: COMMENT=

awsms avatar Sep 23 '24 12:09 awsms

Ah I may have badly written a test.

Would you mind testing this? remove the album/scan (not full)/readd the album/scan (not full) And tell me how it goes?

epoupon avatar Sep 23 '24 12:09 epoupon

After moving the album to somewhere outside of the library folder, rescan, re-move it to the library folder, then rescan : it works!

awsms avatar Sep 23 '24 12:09 awsms

Ok, so it works but the migration is not handled :(

epoupon avatar Sep 23 '24 14:09 epoupon

Sorry to bump this, but could you please update the Docker image for lms ? I really want to try out the feature in my prod env :smile:

awsms avatar Oct 12 '24 00:10 awsms

Hello! Images have been pushed!

epoupon avatar Oct 12 '24 05:10 epoupon