fast-deep-equal icon indicating copy to clipboard operation
fast-deep-equal copied to clipboard

toString comparison breaks if object has toString that isn't a function

Open master-elodin opened this issue 1 year ago • 1 comments

If there is data passed into equals that has toString as a field that's not a function, equals breaks because it tries to call it as a function.

Example data: { field: "status", fieldtype: "jira", fieldId: "status", from: "10000", fromString: "To Do", to: "3", toString: "In Progress" }

I know that it's not ideal to have a field named toString, but this is external data that I don't have any control over.

master-elodin avatar Sep 22 '23 17:09 master-elodin

Actually, it looks like there's a PR that's been open for this since August 2022 - https://github.com/epoberezkin/fast-deep-equal/pull/134

master-elodin avatar Sep 22 '23 17:09 master-elodin