embed-privacy icon indicating copy to clipboard operation
embed-privacy copied to clipboard

Replace custom post type with something more lightweight

Open MatzeKitt opened this issue 2 years ago • 1 comments

What feature are you requesting?

The custom post type for embeds is quite heavy in resource usage. Additionally, there is no benefit in using a CPT here. This should be changed to a simple option with serialized data with an easier interface for editing, while maintaining the same functionality:

  • Allow editing the title
  • Allow editing the overlay message
  • Allow editing the regular expression
  • Allow editing the privacy policy URL
  • Allow editing the background image
  • Allow editing the logo

Why is this feature necessary?

Improved performance and less data in database

Are you expecing side-effects?

No response

Code of Conduct

  • [X] I agree to follow this project's Code of Conduct

MatzeKitt avatar Aug 07 '23 08:08 MatzeKitt

Don’t do it this way. Check for other possibilities to limit its usage. Maybe adding a wrapper to only request data we need instead of full WP_Post objects.

However, it’s not a big issue so far, so maybe we leave it as is, for now.

MatzeKitt avatar Apr 17 '24 18:04 MatzeKitt