Manos Pitsidianakis comments

Results 85 comments of


                                            Manos Pitsidianakis

TLS not working due to certificate expiration date checks.

TLS libraries check that remote certificates have not expired. Since the dates are tampered with, they will not see valid certificates (i.e certificates that have expiration date in the future)

configure: error: libmpfr not found or uses a different ABI (including static vs shared).

Same problem on debian 12.

Setup docker container network with postfix for testing

It'd be great if we could use a Rust based solution as well, with something like https://github.com/fussybeaver/bollard

This file requires compiler and library support for the ISO C++ 2011 standard. This support must be enabled with the -std=c++11 or -std=gnu++11 compiler options.

See https://github.com/ruediger/VobSub2SRT/issues/67#issuecomment-363196505

vhost-device-spi: Add initial implementation

A humble request: resolve old review comments that have been addressed. Thanks!

vhost-device-spi: Add initial implementation

Since 1.4 has not been ratified yet, should we move this to `staging/`? @stefano-garzarella what do you think?

vhost-device-spi: Add initial implementation

@HaixuCui I resolved most of the left over comments. Would you like to resolve what is left yourself and select "Re-request review" when you're done? By the way, it seems...

vhost-device-spi: Add initial implementation

> I cannot add testcase to cover detect_supported_features function in spi.rs, because it interacts with the real hardware, while it is quite a bit function. It could be mocked but...

vsock: cargo-audit reports that `yaml-rust` is unmaintained

An alternative would be to switch to `toml`, WDYT?

sound: test_pipewire_backend_invalid_stream panics with "Failed to connect to core: CreationFailed"

Other failures with the same error: > 2024-07-29 18:03:40 EEST audio_backends::pipewire::tests::test_pipewire_backend_invalid_stream > 2024-07-29 18:03:40 EEST audio_backends::pipewire::tests::test_pipewire_backend_success https://buildkite.com/rust-vmm/vhost-device-ci/builds/2577#0190ff03-fec1-4b56-baa9-036d8558e628 > 2024-07-22 08:24:21 EEST failures: > 2024-07-22 08:24:21 EEST audio_backends::pipewire::tests::test_pipewire_backend_invalid_stream https://buildkite.com/rust-vmm/vhost-device-ci/builds/2528#0190d8e5-05e6-4285-b712-7fa32325b738 > >...