vuestic-ui icon indicating copy to clipboard operation
vuestic-ui copied to clipboard

Prefer vue v-bind instead of :style on dom elements in components.

Open m0ksem opened this issue 2 years ago • 2 comments

For example, it is required to use !important to restyle va-card because it explicitly has background declared in style attribute. That is not intuitive, so I'd prefer moving to CSS variables where in style tag we define new value for css variable, instead of style. It is pretty simple with v-bind.

Reproduce: Try to change va-card background with css without important and nothing happens.

BTW, --va-card-background-color is useless because even if it redefined background color from prop is taken. Consider deleting this css variable?

m0ksem avatar Dec 28 '22 12:12 m0ksem

Can we try it on one component, review, then figure out if we want continue with that?

Would be nice to have an estimate on how much would it take.

asvae avatar Dec 29 '22 09:12 asvae

Deal with https://github.com/epicmaxco/vuestic-ui/issues/3046 at first.

m0ksem avatar Feb 22 '23 21:02 m0ksem