Remove VaSeparator

[rustem-nasyrov]

We have the VaSeparator component and it looks like we removed docs for it or wasn't created them. Or we decided to replace this component with a VaDivider?

Path: packages/ui/src/components/va-separator/VaSeparator.vue.

Probably makes sense to leave it as class:

• as we already have divider component
• it makes sense in context of typography, so user would probably use typography wrapper and hr or class.
• let's also check refs

[asvae]

Hmm, pretty weird component, probably also very old.

It's probably meant as a style component (restyle of hr). I'm not sure if it has a place in our current system. It's probably also not being used given it doesn't have docs.

[rustem-nasyrov]

@asvae I saw usage of it in the vuestic-admin.

UPD: https://github.com/epicmaxco/vuestic-admin/search?q=va-separator

[kushich]

@asvae Looks like it is a deprecated component which doesn't have required attributes like

role="separator" aria-orientation=""

And there are use cases in vuestic admin

We have va-divider component which supports those attributes, so I think that we just forgot to delete this component.

[mdai-vss]

I noticed these two are different with VaDivider having --va-divider-margin: 0.5rem as shown above, while VaSeparator looks like this: So I wonder which was originally the intended visual effect.

Speaking of which, working with VaSeparator has led me to this finding: https://github.com/epicmaxco/vuestic-ui/search?q=var%28--va-divider%29&type=code Should var(--va-divider) be replaced by var(--va-divider-color) instead?

[m0ksem]

I would say it must have var(--va-background-element) color. And there are must be one single component without any margins by default.