vuestic-ui icon indicating copy to clipboard operation
vuestic-ui copied to clipboard

Published 20 hours ago • verified publisher icon epicmaxco

Fix/dark theme flashbang

Open m0ksem opened this issue 1 year ago • 2 comments

closes https://github.com/epicmaxco/vuestic-ui/issues/2419

Optimized only for production. Idk how to fix this in SPA... We need to wait until all js loaded and parsed and then bg can be changed.

m0ksem avatar Sep 21 '22 22:09 m0ksem

@m0ksem can you check this? https://caniuse.com/prefers-color-scheme

asvae avatar Sep 22 '22 11:09 asvae

@m0ksem can you check this? https://caniuse.com/prefers-color-scheme

I could hardcode colors for docs, but it is not solution for vuestic-ui. User must hardcode it too.

Flash caused because body has white BG until we register CSS variables. Unfortunately, we need to wait for all components to be registered and then CSS variables can be rendered in DOM.

I thought about running CSS variables update before registering components. Registering components takes 90% of all rendering time.

m0ksem avatar Sep 22 '22 11:09 m0ksem

Require https://github.com/epicmaxco/vuestic-ui/pull/2438 to be merged before.

m0ksem avatar Oct 03 '22 10:10 m0ksem

Can't we just hack a small script into docs index.html's head?

asvae avatar Jan 03 '23 10:01 asvae

Can't we just hack a small script into docs index.html's head?

Might be fixable after https://github.com/epicmaxco/vuestic-ui/issues/2623

m0ksem avatar Jan 03 '23 12:01 m0ksem

Hope to fix this in nuxt later.

m0ksem avatar Jan 24 '23 11:01 m0ksem