seismometer icon indicating copy to clipboard operation
seismometer copied to clipboard

Enhance handling of model outputs

Open gbowlin opened this issue 1 year ago • 2 comments

We do a check if the scores are all between some value and 100, and if so we divide by 100 so that we get percent values.

We should consider removing this code, or making this an explicit option in config.

Originally posted by @gbowlin in https://github.com/epic-open-source/seismometer/pull/30#discussion_r1653325281

        if 50 < dataframe[score].max() <= 100:  # Assume out of 100, readjust
            dataframe[score] /= 100

gbowlin avatar Jun 26 '24 13:06 gbowlin

Adding part of my response, I think this should be reconsidered in combination with a notebook template extending to new output types. My first thought being, we'll need a flag or enum in configuration.

The next in line for support may mean that Draft Text does this, though regression support might be implemented first.

diehlbw avatar Jun 26 '24 14:06 diehlbw

related to #51, if we know the score type, this can be implicit rather than inferred.

gbowlin avatar Jul 30 '24 12:07 gbowlin