seismometer icon indicating copy to clipboard operation
seismometer copied to clipboard

Clean up dependency for OTEL manager classes

Open gbowlin opened this issue 5 months ago • 3 comments

AutomationManager depends on ExportManager TelemetryRecorder depends on ExportManager and AutomationManager

ExportManager now accepts a single init param ExportConfig

Fixed related Unit tests.

Overview

Closes #xxx

Description of changes

Author Checklist

  • [ ] Linting passes; run early with pre-commit hook.
  • [ ] Tests added for new code and issue being fixed.
  • [ ] Added type annotations and full numpy-style docstrings for new methods.
  • [ ] Draft your news fragment in new changelog/ISSUE.TYPE.rst files; see changelog/README.md.

gbowlin avatar Aug 11 '25 18:08 gbowlin

I can write it up as a separate issue, but re:OTEL "clean up":

Do we really expect that 18 new ci jobs are needed around this? (all combinations of otel true and false).
I get having a couple jobs with one state (ex False) and then the full OS x pyversion matrix with the other.

If it's not something you think we should be concerned with, I could see that argument too

diehlbw avatar Oct 08 '25 11:10 diehlbw

@diehlbw this needs re-review because I've updated the metric recording to fix an issue with labels recorded to OTEL metrics.

gbowlin avatar Oct 19 '25 16:10 gbowlin

I can write it up as a separate issue, but re:OTEL "clean up":

Do we really expect that 18 new ci jobs are needed around this? (all combinations of otel true and false). I get having a couple jobs with one state (ex False) and then the full OS x pyversion matrix with the other.

If it's not something you think we should be concerned with, I could see that argument too

Yeah, I would rather we test too much rather than too little.

gbowlin avatar Nov 18 '25 16:11 gbowlin