Alyx

Results 453 comments of Alyx

Changing `input.value` with JS also doesn't trigger an event we can use to re-check the validity. A `validitychange` event would be super convenient for that too.

umzug is able to execute raw sql files, I think we should support it: https://github.com/sequelize/umzug/tree/main/examples/3.raw-sql. Maybe with a different naming scheme: `migrations/2020.11.24T18.00.40.users/up.sql` & `migrations/2020.11.24T18.00.40.users/down.sql`?

This PR looks good to me. We'd love for this to land. We had to implement some workarounds in the https://github.com/sequelize/sequelize test suites because our own error messages make heavy...

Well since this repo is now under Sequelize I believe we could review and release it in v6 Since we haven't migrated this decorated to the main repo yet, this...

I forgot one last test: the integration one It tests that the value you put in is properly serialized/deserialized when sent/retrieved from the database. It goes in `test/integration/data-types.test.js` You can...

I'm not sure why test integration test is failing (to be honest it's the first time I look into that test suite). I'll assign this to myself to remind myself...

The new v6 release that includes this? Not sure, I need to find the time to figure out how to write this test

I just resolved the conflicts. If it's ok with @Sasha-hk I'll take over the branch to look into the test issue

Ok so the issue is that `data-types.test` is only there to check that a `parse` method is called on the DataType. It's nowhere nearly as useful as testing that the...

Yep! That branch revamps the test suite completely