Alyx

I'm not seeing any calls to [`Sequelize#close`](https://sequelize.org/api/v7/classes/sequelize#close), try adding that and see if the issue resolves itself

Why was `finished` replaced with `getFinished`? That's not really worth a breaking change `getConnection`, `getConnectionIfExists` & `getFinished` are also bound during `prepareEnvironment`, but I don't see a reason why `FindByPkOptions`...

I'm going to test out Copilot review but I'll double check the output and delete any irrelevant comment Well, it was useless

You're declaring an attribute and an association on the same property, which is not supported. You need to split them in two properties Though I think what you meant to...

Adding support for firebird is a massive undertaking. We'd love to support it, but our current priorities are on improving the existing dialects Sequelize 7 split each dialect to its...

Op.contains for JSON is currently only supported for postgres. See https://github.com/sequelize/sequelize/issues/8853 for the issue about supporting it for other dialects as well as workarounds

This issue is strongly related to https://github.com/sequelize/sequelize/issues/16158, where we discussed making the method throw an `OptimisticLockError` (or similar) if the condition matched no records

I agree with https://github.com/sequelize/sequelize/issues/5827#issuecomment-246118933, the PK should come from previousDataValues. What's going to be complicated is figuring out if there are cases where that is not desirable

This was improved in Sequelize 7, you can import `Lock` at the top level

Your patch looks like the correct solution to me, all we're missing is a regression test