Alyx comments

Results 453 comments of


                                            Alyx

Inconsistent and buggy default value parsing by `queryInterface#describeTable`

A nested property like that works for me, the extra object isn't really going to have any noticeable perf impact considering what the goal of the method is I would...

feat!: add `model` parameter on model hooks run on `sequelize` if they don't have an instance, add `afterCount`

Thinking about this more: - We should give the model definition, not the model itself, so this can be compatible with repository mode in the future - Because of this,...

Unable to deal with special methods/mixins when the primary key implements getters and setters

This is definitely caused by association methods making raw queries, which don't produce models, and therefore don't have getter/setters

Unable to deal with special methods/mixins when the primary key implements getters and setters

It's not something you can fix on your end, I'm also not sure whether it's going to break something, but we'll find out when we implement the fix and run...

Empty rows returning, when n:m assotiation and limit condition, but count is right

It's not, the issue is still open

settings raw as true in sqlite returns JSON as String

The point of `raw` seems to be to bypass most of the work we do on the database value. It was returned parsed in postgres because the `pg` library does...

FEATURE: Support ENUM naming for ENUM reuse.

That's correct, we redesigned the enum type in V7 to make it easier to implement this feature. Combined with a recent change to add "if not exists" to the enum...

Pending migration alert during app startup

Moved to the CLI repo because the core library is not aware of the migrations (it is entirely a cli concern). We could definitely add a cli subcommand that checks...

Pending migration alert during app startup

This is strongly related to the `--dry-run` flag: https://github.com/sequelize/cli/issues/219

Pending migration alert during app startup

This is something you'll need to run before you boot your app and decide whether the app may boot based on the exit status of the cli. The core library,...