ephios icon indicating copy to clipboard operation
ephios copied to clipboard

allow for events to be cancelled

Open jeriox opened this issue 2 years ago • 4 comments

closes #373

jeriox avatar Feb 03 '23 17:02 jeriox

@felixrindt I'm not sure how we want to proceed with a delete button for the event. Should we always offer both options? Or only allow the event to be deleted without being cancelled first when there are no participations?

jeriox avatar Feb 03 '23 17:02 jeriox

Coverage Status

Coverage: 87.697% (-0.3%) from 87.95% when pulling dd99b80e7e2043747e01b917355bb61f835b75e0 on event-cancellation into 8389f0f89bee64e053cc364dc6e030980127c2df on main.

coveralls avatar Feb 03 '23 17:02 coveralls

@felixrindt I'm not sure how we want to proceed with a delete button for the event. Should we always offer both options? Or only allow the event to be deleted without being cancelled first when there are no participations?

I think we should allow both, that is:

  • deleting an event entirely, even if it has participations without sending an email
  • the more graceful approach introduced in this PR.

Maybe we can join the two together into one form. Also, what about the bulk delete action? Should it work on events with participations?

felixrindt avatar Feb 06 '23 10:02 felixrindt

@felixrindt I'm not sure how we want to proceed with a delete button for the event. Should we always offer both options? Or only allow the event to be deleted without being cancelled first when there are no participations?

I think we should allow both, that is:

* deleting an event entirely, even if it has participations without sending an email

* the more graceful approach introduced in this PR.

Maybe we can join the two together into one form. Also, what about the bulk delete action? Should it work on events with participations?

I like that idea. The user could then only have one button with "delete event" and can check a checkbox in the delete view with "notify users about the cancellation". if checked, the textarea for the message appears.

I don't see a reason why the bulk action shouldn't work?

jeriox avatar Feb 06 '23 13:02 jeriox