pgapp Support maps for args

Support maps for args

Open philipcristiano opened this issue 5 years ago • 4 comments

Oct 17 '19 23:10 philipcristiano

I would say, it needs to be backwards-compatible

Oct 18 '19 09:10 seriyps

That's a good point. I meant to make this against my own fork :/

At the moment pgapp points to the devel branch for epgsql. I ran into the examples for this repo breaking when I went to use this.

I'll see if I can get some time to make this backwards compatible and update the examples as well.

Oct 18 '19 10:10 philipcristiano

@seriyps updated, please let me know what you think!

Oct 19 '19 13:10 philipcristiano

It's fine. Another approach would be to just convert proplist to map and use map after that, like it was done in epgsql:

https://github.com/epgsql/epgsql/blob/5304480f24789d370fb637dcc649d12688f525ff/src/epgsql.erl#L155

https://github.com/epgsql/epgsql/blob/5304480f24789d370fb637dcc649d12688f525ff/src/epgsql.erl#L455-L459

But I'm ok with your solution as well. Maybe @davidw have smth to add?

Oct 21 '19 13:10 seriyps