error-feedback-SGD icon indicating copy to clipboard operation
error-feedback-SGD copied to clipboard

Cannot find 'TemporarilyAddMemory'

Open 201419 opened this issue 6 years ago • 2 comments

Hi, your work is so great!

There is a small problem here. I can't find TemporarilyAddMemory this file, but you used from optimizers.TemporarilyAddMemory import TemporarilyAddMemory in the 22nd line of the main.py file.

https://github.com/epfml/error-feedback-SGD/blob/master/main.py#L22

Have you forgotten to upload this file ?

201419 avatar Jun 26 '19 06:06 201419

Thanks for pointing this out! We indeed forgot to clean up our code properly. For now, just commenting out this line should fix the issue. Let me know if it works :)

Saipraneet avatar Jun 26 '19 08:06 Saipraneet

You're welcome. I found class TemporarilyAddMemory in the /utils/convex_opt.py file.

You are right and I can fix it by commenting out this line.

Still have to say, your work is so great!

201419 avatar Jun 29 '19 06:06 201419