disco icon indicating copy to clipboard operation
disco copied to clipboard

Server communication HTTP vs Web sockets

Open Nacho114 opened this issue 2 years ago • 4 comments

Server communication HTTP vs Web sockets

Should we keep HTTP or move to Web sockets?

The benefit of Web sockets is that we can easily push data from server to client, e.g. "model update" or even for hyper parameter tuning #151. These features are more complex with HTTP.

The problems with web sockets are mainly the overhead it adds, although this might be negligible?

Work wise it is worth it given the benefits that we mentioned.

Some reading:

https://blogs.windows.com/windowsdeveloper/2016/03/14/when-to-use-a-http-call-instead-of-a-websocket-or-http-2-0/

Nacho114 avatar Mar 08 '22 16:03 Nacho114

this has been done by @tharvik i think, so we can close this?

martinjaggi avatar Jun 13 '22 15:06 martinjaggi

this has been done by @tharvik i think, so we can close this?

only for decentralized, federated still lacks ws

s314cy avatar Jun 13 '22 15:06 s314cy

@martinjaggi if @tharvik confirms i will be reopen the issue

s314cy avatar Jun 13 '22 18:06 s314cy

Right, federated doesn't use websocket yet

tharvik avatar Jun 14 '22 09:06 tharvik