llm-latent-language icon indicating copy to clipboard operation
llm-latent-language copied to clipboard

Published 20 hours ago • verified publisher icon epfl-dlab

Some minor weird things I noticed

Open Butanium opened this issue 11 months ago • 1 comments

  • The output format of this one seems weird: https://github.com/epfl-dlab/llm-latent-language/blob/1be3cd6eaf14c7408e8f03703d1c1905a6b00c44/Translation.ipynb#L242 E.g. some column are called "de" but contains french words.
  • This line should use lang_latent and not 'en': https://github.com/epfl-dlab/llm-latent-language/blob/1be3cd6eaf14c7408e8f03703d1c1905a6b00c44/Translation.ipynb#L316

Butanium avatar Mar 11 '24 04:03 Butanium

Right! Can you make a pull request?

The df_en_de_fr and its column names not matching the actual languages stem from the fact that we started with de and fr and then since the code is the same for other languages just replace the 'de' with the source language and 'fr' with the target language (or the other way around, not sure anymore).

wendlerc avatar Apr 27 '24 09:04 wendlerc