parso icon indicating copy to clipboard operation
parso copied to clipboard

Introduce pull request annotation for checkstyle errors and failed tests

Open timazet opened this issue 4 years ago • 0 comments

Leverage workflow_run trigger in order to execute workflow that will annotate pull request with found checkstyle errors and failed tests without exposing secrets (as in case of pull_request_target trigger and execution of build tool script commands on pull request code base).

This will be helpful for contributors who submit pull requests from forked repositories to get immediate feedback in case if something is wrong with their pull request rather than going to the Actions tab and finding out at what stage and with what reason workflow is failed.

Actions that provide required annotation in case if they have pull_request context and write permissions are following:

  • https://github.com/ScaCap/action-surefire-report
  • https://github.com/jwgmeligmeyling/checkstyle-github-action

More information on security concerns and triggers specifics:

  • https://securitylab.github.com/research/github-actions-preventing-pwn-requests
  • https://docs.github.com/en/actions/reference/events-that-trigger-workflows#pull_request_target
  • https://docs.github.com/en/actions/reference/events-that-trigger-workflows#workflow_run

timazet avatar Feb 11 '21 08:02 timazet