edp-install icon indicating copy to clipboard operation
edp-install copied to clipboard

feat: Align chart for ingress TLS configuration(#210)

Open alezander86 opened this issue 1 year ago • 1 comments

Pull Request Template

Description

This pull request introduces updates to the oauth2-proxy Ingress template and the associated values.yaml to enhance flexibility and configuration options for ingress resources. The main changes include the capability to specify ingressClassName directly in values.yaml for Kubernetes clusters that support this feature, as well as improvements in handling TLS configurations and host settings for the Ingress resource.

The changes allow users to:

Specify a base URL for the OAuth2 proxy through a new host parameter. If not set, the system generates a default URL based on the pattern "oauth-[namespace].[global DNS wildcard]". Configure TLS more dynamically, with the option to define hosts and secretName directly in values.yaml. These improvements aim to make the Helm chart more adaptable to various deployment environments and requirements.

Fixes # (issue number if available)

Fixes # (issue)

Type of change

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

The changes were tested in a Kubernetes cluster by deploying the updated Helm chart and verifying:

The Ingress resource correctly adopts the specified ingressClassName. The generated host URL correctly reflects the host parameter when specified, and falls back to the default pattern when not. TLS settings are correctly applied to the Ingress, with the ability to specify custom hosts and secret names. Testing steps included:

Deploying the Helm chart with various values.yaml configurations. Checking the generated Ingress resource to verify the applied settings. Testing connectivity to the deployed OAuth2-proxy service through the defined Ingress to ensure proper routing and TLS configuration.

Checklist:

  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [x] Pull Request contain one commit. I squash my commits

alezander86 avatar May 02 '24 18:05 alezander86

/recheck

alezander86 avatar May 03 '24 06:05 alezander86

Let's skip update for now, we are going to deprecate this SSO component

SergK avatar May 31 '24 13:05 SergK