OSCI
OSCI copied to clipboard
Something was missed in Industry drop-down list
Hello, I examine https://opensourceindex.io/
What I did: -Click Industry menu filter -Uncheck "select all" -Scroll down -Check empty line between lines "Healthcare & Pharma" and "Public Sector"
What I got: -Line for FARFETCH organization.
What I expect: -I don't have empty lines inside Industry drop-down menu filter
I check - osci/preprocess/match_company/company_domain_match_list.yaml I assume that industry field was missed for FARFETCH company
Possible solutions:
- Add industry field for FARFETCH with value: "Retail & Hospitality" or "Other"
- Add rules fields in yaml file. Example: "we have set of mandatory fields, this fields cannot be empty"
Thanks.
Thanks for the details on this one @zlidzen and for raising the PR (https://github.com/epam/OSCI/pull/192)
I've got @vlad-isayko tagged to review so we can hopefully merge soon.
Looks like autochecker is needed for this file to make it accurate all the time