Indigo icon indicating copy to clipboard operation
Indigo copied to clipboard

'Calculated values' - Error messages are different in 'Remote' and 'Standalone' modes

Open Svetlana-Asinovskaia opened this issue 3 years ago • 2 comments

Affected versions: Remote, Standalone

Steps to reproduce:

  1. Launch Ketcher (Remote)
  2. Execute 'v2/indigo/calculate' with the following parameters: struct Rstruct.zip options: {smart-layout: true, ignore-stereochemistry-errors: true, mass-skip-error-on-pseudoatoms: false,…} properties: ["molecular-weight", "most-abundant-mass", "monoisotopic-mass", "gross", "mass-composition"]
  3. Repeat steps 1-2 in Standalone mode

Expected result: Error messages are the same in Remote and Standalone modes. Actual result: Remote mode - 'error: Cannot calculate mass for structure with pseudoatoms, template atoms or RSites'. Standalone mode - 'mass: Cannot calculate mass for structure with pseudoatoms, template atoms or RSites'.

Svetlana-Asinovskaia avatar Mar 29 '21 07:03 Svetlana-Asinovskaia

Related issue: https://github.com/epam/ketcher/issues/427

Svetlana-Asinovskaia avatar Mar 29 '21 07:03 Svetlana-Asinovskaia

Since WASM (Standalone) version is completely reworked against server version, don't expect the literal match of error texts! Checking and its errors were redesigned and reworked as well. Just check that the errors are (1) justified and proper for corresponding case, (2) enough clear and properly formulated.

SunFellow avatar Mar 29 '21 09:03 SunFellow

fixed in 1.8.0

even1024 avatar Oct 14 '22 05:10 even1024