Ed Page
Ed Page
There is a lot of design discussion to be had on this. My general stance is PRs is for implementation discussion and all design discussion should be done in issues....
Some prior discussion at #781. I don't see us supporting customization of formatting through serde. Serde doesn't natively support it. To support this, we'd need a newtype that serializes to...
In #781, I mention the following API ideas - Separate APIs for each. When applying botth, we'd either need to store the format style (would rather not do this) or...
> Should we allow customization of digit separators? > > - I don't know. I anticipate significant demand for this feature. However, I don't believe there exists a set of...
> I don't understand what you mean by "overwrite"? I was under the impression that Value and Formatted are generally immutable (not accounting for decor) for users of the toml_edit...
I don't see the formatter being a factory for `Value`s. That feels out of place and incongruous with how people will be using all of this. The most likely API...
> It might be better to incrementally build a separate IntegerFormatOptions object and pass it to a method that performs the formatting in one step: I'd just call that `IntegerFormat`....
I'm tempted to have us experiment with an integer formatter in the newly created `toml_write` as I'm more willing to break that API right now. There are hacks you can...
> Why should formatting a negative number in hexadecimal return an error? This and formatting non-integers as hexadecimal (which is something else I might like to do) seem perfectly natural...
@pastelmind as I mentioned earlier (https://github.com/toml-rs/toml/issues/812#issuecomment-2831345828), I'd like to start with experimenting with this API in `toml_writer`. That is the crate that has all of the knowledge of TOML formatting....